Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refactor, changefeed as worker, capture as manager #45

Merged
merged 1 commit into from
Oct 15, 2019
Merged

minor refactor, changefeed as worker, capture as manager #45

merged 1 commit into from
Oct 15, 2019

Conversation

amyangfei
Copy link
Contributor

According to our design, Capture manages 1-N SubChangeFeed (SubChangeFeed can be treated as task), SubChangeFeed manages TablePuller and DDLPuller if it is the owner.

@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 14, 2019
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku added the LGT1 label Oct 15, 2019
@july2993 july2993 added LGT2 and removed status/ptal Could you please take a look? LGT1 labels Oct 15, 2019
@july2993 july2993 merged commit f24df96 into pingcap:master Oct 15, 2019
@amyangfei amyangfei deleted the capture-changefeed-refactor branch October 16, 2019 02:03
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants