Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc): migrate test-infra to testify for cdc/kv pkg (#2899) #4515

Merged
merged 7 commits into from
Feb 15, 2022
Merged

test(ticdc): migrate test-infra to testify for cdc/kv pkg (#2899) #4515

merged 7 commits into from
Feb 15, 2022

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #2899

What is changed and how it works?

Migrate all test cases under cdc/kv to testify.

Check List

Tests

  • Unit test

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 8, 2022
@purelind
Copy link
Collaborator

purelind commented Feb 8, 2022

/run-dm-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the fix_2899_migrate_kv_test branch 2 times, most recently from 3958d26 to cb30f1f Compare February 9, 2022 16:11
asddongmen
asddongmen reviewed Feb 10, 2022
View reviewed changes
cdc/kv/token_region_test.go Outdated
defer testleak.AfterTest(c)()
s.testRouterWithConsumer(c, func() { time.Sleep(time.Millisecond * 15) })
func TestRouterWithSlowConsumer(t *testing.T) {
defer testleak.AfterTestT(t)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove this line: defer testleak.AfterTestT(t)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already removed, PTAL

@CharlesCheung96 CharlesCheung96 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96 CharlesCheung96 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #4515 (45d6d76) into master (9607554) will decrease coverage by 0.1293%.
The diff coverage is 61.9571%.

Flag Coverage Δ
cdc 60.2080% <59.2427%> (+0.2858%) ⬆️
dm 51.5361% <62.9848%> (-0.4927%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4515        +/-   ##
================================================
- Coverage   55.6402%   55.5109%   -0.1294%     
================================================
  Files           494        506        +12     
  Lines         61283      62494      +1211     
================================================
+ Hits          34098      34691       +593     
- Misses        23750      24332       +582     
- Partials       3435       3471        +36

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests
/run-leak-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 901e6ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit 9ddc713 into pingcap:master Feb 15, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@CharlesCheung96 @zhaoxinyu
test(ticdc): migrate test-infra to testify for cdc/kv pkg (pingcap#2899…
d6aeb6e 
…) (pingcap#4515)

close pingcap#2899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen left review comments

@overvenus overvenus overvenus approved these changes

@ben1009 ben1009 ben1009 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for cdc/kv pkg
7 participants
@CharlesCheung96 @ti-chi-bot @purelind @codecov-commenter @overvenus @ben1009 @asddongmen