-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Capture.Start to support starting multiple pullers #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pls resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@amyangfei @july2993 @leoppro PTAL, adapted for the conflict change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-Authored-By: amyangfei <amyangfei@gmail.com>
Co-Authored-By: amyangfei <amyangfei@gmail.com>
Co-Authored-By: amyangfei <amyangfei@gmail.com>
@amyangfei updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Refactor SubChangeFeed.Start to support starting multiple pullers Co-Authored-By: amyangfei <amyangfei@gmail.com>
* client: decouple clients out of executor managers * refine pkg * add tests * address comment and add more comments
No description provided.