Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Capture.Start to support starting multiple pullers #46

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Refactor Capture.Start to support starting multiple pullers #46

merged 4 commits into from
Oct 15, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Oct 14, 2019

No description provided.

@suzaku suzaku added the status/ptal Could you please take a look? label Oct 14, 2019
@suzaku suzaku requested a review from zier-one October 14, 2019 10:13
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT1 and removed status/ptal Could you please take a look? labels Oct 15, 2019
@july2993
Copy link
Contributor

pls resolve conflicts

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT2 and removed LGT1 labels Oct 15, 2019
@suzaku
Copy link
Contributor Author

suzaku commented Oct 15, 2019

@amyangfei @july2993 @leoppro PTAL, adapted for the conflict change.

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/changefeed.go Outdated Show resolved Hide resolved
cdc/changefeed.go Outdated Show resolved Hide resolved
cdc/changefeed.go Outdated Show resolved Hide resolved
suzaku and others added 3 commits October 15, 2019 11:57
Co-Authored-By: amyangfei <amyangfei@gmail.com>
Co-Authored-By: amyangfei <amyangfei@gmail.com>
Co-Authored-By: amyangfei <amyangfei@gmail.com>
@suzaku
Copy link
Contributor Author

suzaku commented Oct 15, 2019

@amyangfei updated

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku merged commit c609ec1 into pingcap:master Oct 15, 2019
@suzaku suzaku deleted the refactor-capture-start branch October 15, 2019 03:58
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
* Refactor SubChangeFeed.Start to support starting multiple pullers

Co-Authored-By: amyangfei <amyangfei@gmail.com>
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
* client: decouple clients out of executor managers
* refine pkg
* add tests
* address comment and add more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants