Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data inconsistency caused by default value #4652

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Fix data inconsistency caused by default value #4652

merged 3 commits into from
Feb 22, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

This is a manual pr merge(#3846 #4224 #3930)

Issue Number: close #3793 #4223 #3929 #3918

Release note

Support more data types with default value attribute, and fix potential data inconsistency caused by default value logic

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 22, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@4418ec1). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #4652   +/-   ##
================================================
  Coverage               ?   55.5424%           
================================================
  Files                  ?        221           
  Lines                  ?      23681           
  Branches               ?          0           
================================================
  Hits                   ?      13153           
  Misses                 ?       9219           
  Partials               ?       1309           

@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-leak-test

@overvenus overvenus added area/ticdc Issues or PRs related to TiCDC. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Feb 22, 2022
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 22, 2022
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants