Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tidb related dep to latest #492

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

update tidb dependency to fix some region cache bug

What is changed and how it works?

  • run go get github.com/pingcap/tidb@master and go mod tidy
  • fix some compile error due to compatibility

Check List

Tests

  • Unit test
  • Integration test

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Apr 24, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-io
Copy link

Codecov Report

Merging #492 into master will decrease coverage by 1.3006%.
The diff coverage is 13.5900%.

@@               Coverage Diff                @@
##             master       #492        +/-   ##
================================================
- Coverage   29.0322%   27.7316%   -1.3007%     
================================================
  Files            58         59         +1     
  Lines          5673       6260       +587     
================================================
+ Hits           1647       1736        +89     
- Misses         3913       4406       +493     
- Partials        113        118         +5     

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT1 and removed status/ptal Could you please take a look? labels Apr 26, 2020
@amyangfei amyangfei merged commit 364c453 into pingcap:master Apr 26, 2020
@amyangfei amyangfei deleted the update-go-mod branch April 26, 2020 03:52
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants