Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch cherrypick default-value prs to release-5.2 #5156

Merged
merged 7 commits into from
Apr 15, 2022
Merged

Batch cherrypick default-value prs to release-5.2 #5156

merged 7 commits into from
Apr 15, 2022

Conversation

maxshuang
Copy link
Contributor

@maxshuang maxshuang commented Apr 12, 2022 •
edited
Loading

What problem does this PR solve?

This is the batch cherry-pick of #3846 #3930

close issue：#3793 #3929 #3918

Release note 

Fix column default value type unsupported problem and data inconsistency issue.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2022
@maxshuang maxshuang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@maxshuang maxshuang changed the title Batch cherrypick default-value prs [WIP]Batch cherrypick default-value prs Apr 12, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@maxshuang maxshuang changed the title [WIP]Batch cherrypick default-value prs Batch cherrypick default-value prs Apr 12, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@maxshuang maxshuang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@maxshuang
Copy link
Contributor Author

/run-all-tests

This was referenced Apr 12, 2022
Closed
Closed
@maxshuang maxshuang changed the title Batch cherrypick default-value prs Batch cherrypick default-value prs to release-5.2 Apr 12, 2022
@maxshuang
Copy link
Contributor Author

/run-verify

2 similar comments
@maxshuang
Copy link
Contributor Author

/run-verify

@maxshuang
Copy link
Contributor Author

/run-verify

@maxshuang
Copy link
Contributor Author

/run-cla

@maxshuang
Copy link
Contributor Author

/run-all-tests

@maxshuang
Copy link
Contributor Author

/run-integration-test

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@ee1ad70). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #5156   +/-   ##
================================================
  Coverage               ?   57.6721%           
================================================
  Files                  ?        193           
  Lines                  ?      19434           
  Branches               ?          0           
================================================
  Hits                   ?      11208           
  Misses                 ?       7235           
  Partials               ?        991

@overvenus overvenus added this to the v5.2.4 milestone Apr 14, 2022
@maxshuang
Copy link
Contributor Author

/run-all-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test
/run-leak-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 14, 2022
@maxshuang
Copy link
Contributor Author

/run-all-tests

@maxshuang maxshuang added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@maxshuang
Copy link
Contributor Author

/run-all-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

@maxshuang maxshuang added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2022
@asddongmen
Copy link
Contributor

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51ae407

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@asddongmen
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 2746528 into pingcap:release-5.2 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@amyangfei amyangfei amyangfei approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

@overvenus overvenus Awaiting requested review from overvenus

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
7 participants
@maxshuang @ti-chi-bot @codecov-commenter @asddongmen @amyangfei @overvenus @VelocityLight