Add support for deciding the min resolvedTs of all pullers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
reviewed
Oct 16, 2019
cdc/changefeed.go
Outdated
| } | ||
|
|
||
| func (c *SubChangeFeed) startOnSpan(ctx context.Context, span util.Span) error { | ||
| func (c *SubChangeFeed) getCheckpointTs() uint64 { |
There was a problem hiding this comment.
L162 GetResolvedTS is mean that get the local resolved TS in this SubChangeFeed
but getCheckpointTs is mean that get the global checkpointTS from ETCD? it's confusing.
and we also need to calculate loacl checkpointTS, then push it to ETCD
zier-one
reviewed
Oct 16, 2019
| minResolvedTs = ts | ||
| } | ||
| } | ||
| return minResolvedTs | ||
| } |
There was a problem hiding this comment.
we need a public func to get loacl checkpoint ts in this sub changed feed
There was a problem hiding this comment.
Let's leave that for another PR?
|
LGTM |
This reverts commit 8ffa3ac.
|
@amyangfei debug.go updated. |
amyangfei
approved these changes
Oct 16, 2019
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
added a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.