Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM/Openapi: use reverse proxy instead of redirect #5390

Merged
merged 15 commits into from
May 18, 2022
Merged

DM/Openapi: use reverse proxy instead of redirect #5390

merged 15 commits into from
May 18, 2022

Conversation

WizardXiao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5179

What is changed and how it works?

use reverse proxy instead of redirect.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • buchuitoudegou

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2022
@WizardXiao WizardXiao added the area/dm Issues or PRs related to DM. label May 11, 2022
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/cc @Ehco1996 @D3Hunter

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2022
Ehco1996
Ehco1996 reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/dm/master/openapi_view.go Outdated Show resolved Hide resolved
dm/dm/master/openapi_view.go Outdated Show resolved Hide resolved
@D3Hunter
Copy link
Contributor

/run-dm-integration-test

@WizardXiao
Copy link
Contributor Author

/run-all-tests

buchuitoudegou
buchuitoudegou approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@buchuitoudegou buchuitoudegou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/dm/master/openapi_view_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2022
@WizardXiao @buchuitoudegou
Update dm/dm/master/openapi_view_test.go
2d3c939 
Co-authored-by: Obliviate <756541536@qq.com>
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

Ehco1996
Ehco1996 approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels May 18, 2022
@WizardXiao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d3c939

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@WizardXiao
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@WizardXiao
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@WizardXiao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 359af18 into pingcap:master May 18, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 18, 2022
@WizardXiao @ti-chi-bot
This is an automated cherry-pick of pingcap#5390
8da4d22 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5465.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 18, 2022
@WizardXiao @ti-chi-bot
This is an automated cherry-pick of pingcap#5390
b8ae854 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5466.

ti-chi-bot added a commit that referenced this pull request May 24, 2022
@ti-chi-bot
DM/Openapi: use reverse proxy instead of redirect (#5390) (#5465)
1feef71 
close #5179
ti-chi-bot added a commit that referenced this pull request May 25, 2022
@ti-chi-bot
DM/Openapi: use reverse proxy instead of redirect (#5390) (#5466)
f49b3d3 
close #5179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm openapi should use reverse proxy instead of redirect
5 participants
@WizardXiao @ti-chi-bot @D3Hunter @Ehco1996 @buchuitoudegou