-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(ticdc): Add alias for "dispatcher" in dispatch rules #5441
config(ticdc): Add alias for "dispatcher" in dispatch rules #5441
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5441 +/- ##
================================================
- Coverage 56.1240% 55.7591% -0.3649%
================================================
Files 522 528 +6
Lines 65325 69646 +4321
================================================
+ Hits 36663 38834 +2171
- Misses 25094 27085 +1991
- Partials 3568 3727 +159 |
@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
@overvenus |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 781913d
|
/run-leak-test |
What problem does this PR solve?
Issue Number: close #4423
What is changed and how it works?
Add alias for "dispatcher" in dispatch rules of sink configuration.
For example:
Note:
dispatcher
andpartition
cannot be configured both. Thus, the following dispatch rule is invalid:Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
Yes, the user doc should be updated.
Release note