Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): Add alias for "dispatcher" in dispatch rules #5441

Merged
merged 12 commits into from
May 17, 2022

Conversation

zhaoxinyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4423

What is changed and how it works?

Add alias for "dispatcher" in dispatch rules of sink configuration.
For example:

[sink]
dispatchers = [
    # these lines are completely equal
    {matcher = ['*.*'], dispatcher = "ts"},
    {matcher = ['*.*'], partition = "ts"},
 
    # these lines are completely equal
    {matcher = ['*.*'], dispatcher = "rowid", topic = "{schema}_{table}},
    {matcher = ['*.*'], partition = "rowid", topic = "{schema}_{table}},
]

Note: dispatcher and partition cannot be configured both. Thus, the following dispatch rule is invalid:

    {matcher = ['*.*'], dispatcher = "ts", partition = "rowid"},

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes, the user doc should be updated.

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2022
@zhaoxinyu zhaoxinyu requested a review from Rustin170506 May 16, 2022 14:24
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2022
@zhaoxinyu zhaoxinyu requested a review from zier-one May 16, 2022 14:24
@Rustin170506 Rustin170506 changed the title conf/(ticdc): Add alias for "dispatcher" in dispatch rules config(ticdc): Add alias for "dispatcher" in dispatch rules May 16, 2022
pkg/config/sink.go Show resolved Hide resolved
pkg/config/sink.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #5441 (084c033) into master (687e248) will decrease coverage by 0.3648%.
The diff coverage is 51.7857%.

Flag Coverage Δ
cdc 60.6745% <51.7857%> (+0.0759%) ⬆️
dm 51.9340% <ø> (-0.5356%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5441        +/-   ##
================================================
- Coverage   56.1240%   55.7591%   -0.3649%     
================================================
  Files           522        528         +6     
  Lines         65325      69646      +4321     
================================================
+ Hits          36663      38834      +2171     
- Misses        25094      27085      +1991     
- Partials       3568       3727       +159     

@ti-chi-bot
Copy link
Member

@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhaoxinyu zhaoxinyu requested a review from Rustin170506 May 17, 2022 02:14
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/cmd/util/helper_test.go Outdated Show resolved Hide resolved
pkg/cmd/util/helper_test.go Show resolved Hide resolved
pkg/config/sink.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@Rustin170506 Rustin170506 requested a review from overvenus May 17, 2022 04:51
@Rustin170506
Copy link
Member

@overvenus
Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

@zhaoxinyu zhaoxinyu requested a review from CharlesCheung96 May 17, 2022 06:27
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 781913d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@zhaoxinyu
Copy link
Contributor Author

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 119dbe0 into pingcap:master May 17, 2022
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for multiple topics
6 participants