kv(ticdc): fix data loss when upstream txn conflicts during scan (#5477) #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
release-note
MimeLyc
added
cherry-pick-approved
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: fa85934
|
ti-chi-bot
added
the
status/can-merge
|
/run-leak-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5477
What problem does this PR solve?
Issue Number: close #5468
What is changed and how it works?
Do not match prewrite and commit util it receives init event.
See more in #5468
Check List
Tests
Will it cause performance regression or break compatibility?
It caches more events in memory during incremental scan, it cause OOM when upstream workload is write-heavy.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note