cmd: add dial timeout and verify sink connection status #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
amyangfei
reviewed
May 12, 2020
| @@ -297,6 +297,11 @@ func newMySQLSink(ctx context.Context, sinkURI *url.URL, dsn *dmysql.Config, fil | |||
| if err != nil { | |||
| return nil, errors.Annotatef(err, "Open database connection failed, dsn: %s", dsnStr) | |||
| } | |||
| err = db.PingContext(ctx) | |||
| if err != nil { | |||
| return nil, errors.Annotatef(err, "fail to open MySQL connection") | |||
There was a problem hiding this comment.
also add dsnStr in the error message?
There was a problem hiding this comment.
It could leak the password.
There was a problem hiding this comment.
Oh, yes. Seems dsnStr in L298 also needs to be removed
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
================================================
- Coverage 32.2043% 32.1376% -0.0667%
================================================
Files 69 69
Lines 6909 6914 +5
================================================
- Hits 2225 2222 -3
- Misses 4524 4532 +8
Partials 160 160 |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add dial timeout and verify sink connection when creating changefeed.
Cc pingcap/ticdc#542
Check List
Tests
Related changes
Release note