Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: when context is done, send to chan will be block #574

Merged
merged 1 commit into from
May 15, 2020
Merged

sink: when context is done, send to chan will be block #574

merged 1 commit into from
May 15, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Fix bug in https://github.com/pingcap/ticdc/issues/573

What is changed and how it works?

send to channel in select mode, with ctx.Done() check

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added the component/sink Sink component. label May 14, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

zier-one
zier-one approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the LGT1 label May 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #574 into master will increase coverage by 0.0420%.
The diff coverage is 50.0000%.

@@               Coverage Diff                @@
##             master       #574        +/-   ##
================================================
+ Coverage   32.5681%   32.6102%   +0.0420%     
================================================
  Files            71         71                
  Lines          7188       7191         +3     
================================================
+ Hits           2341       2345         +4     
  Misses         4682       4682                
+ Partials        165        164         -1

@amyangfei amyangfei added LGT2 and removed LGT1 labels May 15, 2020
@amyangfei amyangfei merged commit 183bfc4 into pingcap:master May 15, 2020
@amyangfei amyangfei deleted the fix-mysql-sink-block branch May 15, 2020 03:16
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
sink: when context is done, send to chan will be block (pingcap#574)
0f8a7d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
component/sink Sink component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @codecov-io @overvenus @zier-one