owner: implement a basic owner, it can calculation resolvedTS #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
changed the title
suzaku
reviewed
Oct 21, 2019
|
@suzaku PTAL again |
suzaku
reviewed
Oct 22, 2019
amyangfei
reviewed
Oct 22, 2019
amyangfei
reviewed
Oct 22, 2019
amyangfei
reviewed
Oct 22, 2019
amyangfei
reviewed
Oct 22, 2019
suzaku
reviewed
Oct 22, 2019
| // ChangeFeedInfoRWriter defines the Reader and Writer for ChangeFeedInfo | ||
| type ChangeFeedInfoRWriter interface { | ||
| // Read the changefeed info from storage such as etcd. | ||
| Read(ctx context.Context) (map[ChangeFeedID]ProcessorsInfos, error) |
There was a problem hiding this comment.
How are you planning to implement Read?
There was a problem hiding this comment.
I think we can read all of change feed info
suzaku
reviewed
Oct 22, 2019
| zap.Reflect("ddlJob", todoDDLJob)) | ||
| return | ||
| } | ||
| if cfInfo.status != ChangeFeedExecDDL { |
There was a problem hiding this comment.
When would this be set to something unexpected? It seems that it's just set before the goroutine starts.
There was a problem hiding this comment.
Just to be sure, If cfInfo.status is changed for some reason(such as concurrency problem), the correctness of data will be broke, we need a obviously error.
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
pushed a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
part job of pingcap#60 This PR supports the suspending of jobs and tasks, but it hasn't considered the consistency after fail-over. The "suspend" is implemented in an async way, because suspending might happen when rescheduling or fail recovering. After the user sends suspend request, we mark the "target status" for the target tasks. A goroutine will check the status regularly, and will try to suspend it util success. There are some work to do furture. * The commands should be serializable. If several commands are sent in the same time, we should order them. * The command have to be persisted and to be continued when node crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement a basic owner, it can calculation global resolvedTS
it can‘t calculation global checkpointTS now.
it can‘t handle the increase or remove of changfeed
it can‘t handle the increase or remove of subchangfeed
it can‘t handle the increase or remove of table
What is changed and how it works?
Check List
Tests