Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go module for revive tool #65

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Fix go module for revive tool #65

merged 2 commits into from
Oct 23, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Oct 22, 2019 •
edited
Loading

What problem does this PR solve?

The go module files used for building revive is generated with go1.12, after upgrading to go1.13, running make check will meet the following error

➜  make check
gofmt (simplify)
cd tools/check; \
GO111MODULE=on go build -o ../bin/revive github.com/mgechev/revive
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-ee9bf5809ead: invalid pseudo-version: does not match version-control timestamp (2019-02-10T22:04:43Z)
make: *** [Makefile:94: tools/bin/revive] Error 1

What is changed and how it works?

  • remove go.mod, go.sum
  • rebuild revive and generate new go.mod, go.sum

Check List

Tests

  • No code

Code changes

Side effects

Related changes

@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 22, 2019
@suzaku suzaku added LGT1 and removed status/ptal Could you please take a look? labels Oct 23, 2019
@zier-one
Copy link
Contributor

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Oct 23, 2019
@amyangfei amyangfei merged commit 00182b0 into pingcap:master Oct 23, 2019
@amyangfei amyangfei deleted the fix-revive-module branch October 23, 2019 02:39
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
Fix go module for revive tool (pingcap#65)
6da1547
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
@liuzix
pkg/p2p: add some helper structs for integrating p2p (pingcap#65)
ed9f956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyangfei @zier-one @suzaku