Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dm): add test for json #7022

Merged
merged 8 commits into from
Sep 14, 2022
Merged

test(dm): add test for json #7022

merged 8 commits into from
Sep 14, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Sep 8, 2022 •
edited by lance6716
Loading

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2022
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Sep 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022 •
edited
Loading

Codecov Report

Merging #7022 (1992359) into master (9398176) will increase coverage by 0.0241%.
The diff coverage is 60.5577%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.1929% <61.5550%> (-0.0031%) ⬇️
dm 51.9082% <50.0000%> (-0.0398%) ⬇️
engine 62.4406% <60.1547%> (+0.1784%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7022        +/-   ##
================================================
+ Coverage   59.8253%   59.8495%   +0.0241%     
================================================
  Files           791        792         +1     
  Lines         90221      90639       +418     
================================================
+ Hits          53975      54247       +272     
- Misses        31498      31627       +129     
- Partials       4748       4765        +17

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei xiongjiwei marked this pull request as ready for review September 13, 2022 02:38
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
lance6716
lance6716 reviewed Sep 13, 2022
View reviewed changes
dm/tests/all_mode/run.sh Show resolved Hide resolved
dm/tests/all_mode/data/db3.prepare.sql Outdated Show resolved Hide resolved
dm/tests/all_mode/data/db3.prepare.sql Show resolved Hide resolved
@lance6716
Copy link
Contributor

/cc @GMHDBJD

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

2 similar comments
@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

@xiongjiwei
Copy link
Contributor Author

/run-dm-integration-test

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2022
@lance6716
Copy link
Contributor

/cc @GMHDBJD @buchuitoudegou

GMHDBJD
GMHDBJD approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 14, 2022
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Sep 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1992359

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2022
@lance6716 lance6716 changed the title dm: add test for json test(dm): add test for json Sep 14, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@xiongjiwei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8cf3109 into pingcap:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongjiwei @ti-chi-bot @codecov-commenter @lance6716 @GMHDBJD