Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: support to configure kafka-client-id in mq sink-uri #706

Merged
merged 4 commits into from
Jul 1, 2020
Merged

sink: support to configure kafka-client-id in mq sink-uri #706

merged 4 commits into from
Jul 1, 2020

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jul 1, 2020 •
edited
Loading

What problem does this PR solve?

Support user to configure kafka-client-id in sink-uri

What is changed and how it works?

Extract kafka-client-id from sink-uri and pass it to KafkaConfig

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation

Release note

  • Support to configure kafka-client-id in the mq sink-uri

@amyangfei amyangfei added the component/sink Sink component. label Jul 1, 2020
@amyangfei amyangfei added this to the v4.0.3 milestone Jul 1, 2020
@amyangfei amyangfei added the status/ptal Could you please take a look? label Jul 1, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

zier-one
zier-one approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the LGT1 label Jul 1, 2020
overvenus
overvenus approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus
Copy link
Member

/run-integration-tests

@amyangfei amyangfei added LGT2 and removed LGT1 status/ptal Could you please take a look? labels Jul 1, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #706 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #706   +/-   ##
===========================================
  Coverage   30.9508%   30.9508%           
===========================================
  Files            90         90           
  Lines          9570       9570           
===========================================
  Hits           2962       2962           
  Misses         6367       6367           
  Partials        241        241

@amyangfei amyangfei merged commit 2d109a2 into pingcap:master Jul 1, 2020
@amyangfei amyangfei deleted the kafka-client-id branch July 1, 2020 07:07
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
sink: support to configure kafka-client-id in mq sink-uri (pingcap#706)
c42e70f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
component/sink Sink component.
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @overvenus @codecov-commenter @zier-one