Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(DM): add check log contain to safe-mode integration test #7152

Merged
merged 6 commits into from
Sep 21, 2022
Merged

test(DM): add check log contain to safe-mode integration test #7152

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d2b01d
add sleep
okJiang Sep 21, 2022
6aed944
fix comment: add check_log_contain_with_retry to make sure worker1 en…
okJiang Sep 21, 2022
0febd96
update log content
okJiang Sep 21, 2022
24f8d1d
remove test
okJiang Sep 21, 2022
97981a0
Merge branch 'master' into okJiang/fix-unstable-7099
okJiang Sep 21, 2022
4cb3fef
Merge branch 'master' into okJiang/fix-unstable-7099
ti-chi-bot Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dm/tests/safe_mode/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ function safe_mode_duration() {
dmctl_operate_source create $WORK_DIR/source2.yaml $SOURCE_ID2

dmctl_start_task "$cur/conf/dm-task-safe-mode-duration.yaml" "--remove-meta"
# Worker1 need to start relay, so it is slow.
# It is possible that worker1 has not loaded before check diff.
sleep 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think sleep can make it stable, you may use check_log_contains_with_retry to make sure test enter a centain state.

check_sync_diff $WORK_DIR $cur/conf/diff_config.toml

run_sql_file $cur/data/db1.increment.sql $MYSQL_HOST1 $MYSQL_PORT1 $MYSQL_PASSWORD1
Expand Down