Keep track of resolved timestamps with a channel #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
zier-one
reviewed
Oct 28, 2019
| @@ -127,5 +133,13 @@ func (p *Puller) GetResolvedTs() uint64 { | |||
| } | |||
|
|
|||
| func (p *Puller) CollectRawTxns(ctx context.Context, outputFn func(context.Context, txn.RawTxn) error) error { | |||
| return txn.CollectRawTxns(ctx, p.buf.Get, outputFn, p.tsTracker) | |||
| forwardResolve := func(ctx2 context.Context, ts uint64) error { | |||
There was a problem hiding this comment.
how about get resolvedTS in L120? and we needn't onResolved function.
There was a problem hiding this comment.
This is not the same. The L120 one is just a partial resolved ts, what we get here is the one determined by SpanFrontier which considers resolved ts from all regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
A channel is needed to notify the processor of new resolved ts.
What is changed and how it works?
Keep track of resolved ts with a channel.
Check List
Tests
Code changes
Side effects
Related changes