Add a channel-based interface for sink to allow batch processing #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zier-one
reviewed
Oct 30, 2019
| return s.successC | ||
| } | ||
|
|
||
| func (s *mysqlSink) Error() <-chan error { |
There was a problem hiding this comment.
It seems like we don't use Error now.
There was a problem hiding this comment.
If we are writing to the database asynchronously, we need a way to let the callers know what's wrong? Like syncers in Binlog?
There was a problem hiding this comment.
yes, I understand the effect of errorC, but when Emit returns an error, should we put the failed Txn into errorC?
|
Replaced by #182 |
amyangfei
pushed a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
* add demotask server and client * remove the temp data files * fix the make check error * fix the some errors case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
With
Emitwe can only processtxn.Txns one by one.What is changed and how it works?
The original
Emitmethod is still kept so that I don't have to rewrite large part of the old code.Check List
Tests
Code changes
Side effects
Related changes