Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-master(engine): update readme #7729

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #7728

What is changed and how it works?

  • Refine document of server master

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label Nov 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #7729 (f572929) into master (6d24a57) will increase coverage by 0.0305%.
The diff coverage is 71.3592%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.3338% <75.0000%> (+0.0319%) ⬆️
dm 52.1439% <56.1728%> (-0.0414%) ⬇️
engine 64.1746% <91.6666%> (+0.1777%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7729        +/-   ##
================================================
+ Coverage   59.9034%   59.9339%   +0.0305%     
================================================
  Files           810        814         +4     
  Lines         93255      93628       +373     
================================================
+ Hits          55863      56115       +252     
- Misses        32535      32635       +100     
- Partials       4857       4878        +21     

@amyangfei amyangfei added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f572929

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit 802c73e into pingcap:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants