processor/sinkmanager(ticdc): background GC sort engine data #7737
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7737 +/- ##
================================================
+ Coverage 55.0067% 59.9786% +4.9719%
================================================
Files 415 812 +397
Lines 52739 93735 +40996
================================================
+ Hits 29010 56221 +27211
- Misses 20957 32628 +11671
- Partials 2772 4886 +2114 |
ti-chi-bot
added
size/XL
Rustin170506
added
component/sink
|
/run-all-tests |
ti-chi-bot
added
status/LGT1
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
cdc/processor/sinkmanager/manager.go
Outdated
| select { | ||
| case m.engineGCChan <- gcEvent: | ||
| default: | ||
| log.Debug("Failed to send GC event to engine GC channel, engine GC channel is full", |
There was a problem hiding this comment.
How about change the log level to Warn?
There was a problem hiding this comment.
I guess it will be too annoying.
There was a problem hiding this comment.
If they are dropped, we must have some ways to know it and then we can fix it.
|
Rest LGTM. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d2757cc
|
ti-chi-bot
added
the
status/can-merge
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #5928
See #5928 (comment)
What is changed and how it works?
Background GC sort engine data.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note