Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): support gcs scheme in redo log (#7993) #8016

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7993

What problem does this PR solve?

Issue Number: close #7987, close #6335

What is changed and how it works?

  1. Extract external_storage util to manage external storage creation.
  2. Extract pkg/redo and add support to gcs and azure scheme.
  3. Add ConsistentConfig.ValidateAndAdjust.
  4. Refactor code and test structure, and remove some useless logic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jan 4, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 4, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-7993-to-release-6.1 branch 2 times, most recently from baff0a0 to 5d12faf Compare January 4, 2023 14:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@38f1d35). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 714ea87 differs from pull request most recent head 9d46704. Consider uploading reports for the commit 9d46704 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 61.6854% <0.0000%> (?)
dm 52.1676% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #8016   +/-   ##
================================================
  Coverage               ?   56.4627%           
================================================
  Files                  ?        548           
  Lines                  ?      71548           
  Branches               ?          0           
================================================
  Hits                   ?      40398           
  Misses                 ?      27289           
  Partials               ?       3861           

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9d46704

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2023
@CharlesCheung96
Copy link
Contributor

/run-verify

@ti-chi-bot ti-chi-bot merged commit f69c799 into pingcap:release-6.1 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants