Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): use uuid in redo meta filename (#8075) #8129

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8075

What problem does this PR solve?

Issue Number: close #8074, close #8028

What is changed and how it works?

  1. Use uuid in redo meta filename to avoid frequent access to the same object.

  2. Add metricRedoWorkerBusyRatio to redoManager.
    image

  3. Fix the limit on flush-interval.

  4. Add test.Dockerfile facilitate testing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 30, 2023
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. do-not-merge/cherry-pick-not-approved labels Jan 30, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 30, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@d418b6d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 62c2900 differs from pull request most recent head e4100f9. Consider uploading reports for the commit e4100f9 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 65.5197% <0.0000%> (?)
dm 56.0173% <0.0000%> (?)
engine 65.2393% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #8129   +/-   ##
================================================
  Coverage               ?   61.0906%           
================================================
  Files                  ?        998           
  Lines                  ?     134230           
  Branches               ?          0           
================================================
  Hits                   ?      82002           
  Misses                 ?      45422           
  Partials               ?       6806           

@CharlesCheung96
Copy link
Contributor

/hold wait for validating test_infra tests

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
@CharlesCheung96
Copy link
Contributor

/unhold test pass, plan id: 1590052, 1590053

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 8, 2023
@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e4100f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@CharlesCheung96
Copy link
Contributor

/run-integration-test
/run-verify

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test

2 similar comments
@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 992ae65 into pingcap:release-6.1 Feb 14, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants