Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmctl: fix error and add test for binlog-schema delete #8180

Merged
merged 3 commits into from
Feb 9, 2023
Merged

dmctl: fix error and add test for binlog-schema delete #8180

merged 3 commits into from
Feb 9, 2023

Conversation

liumengya94
Copy link
Contributor

@liumengya94 liumengya94 commented Feb 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7373

What is changed and how it works?

Use SchemaOp_RemoveSchema in newSourceTableSchemaDeleteCmd.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2023
@liumengya94
Copy link
Contributor Author

/label needs-cherry-pick-release-6.1

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Feb 6, 2023
@liumengya94
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Feb 6, 2023
@liumengya94
Copy link
Contributor Author

/cc @D3Hunter @lance6716

@lance6716 lance6716 changed the title fix error and add test for binlog-schema delete dmctl: fix error and add test for binlog-schema delete Feb 6, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
@lance6716
Copy link
Contributor

cc @GMHDBJD

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2a82f8b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2023
@lance6716
Copy link
Contributor

/run-dm-integration-test
/run-verify

@ti-chi-bot
Copy link
Member

@liumengya94: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b644055 into pingcap:master Feb 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 9, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8207.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 9, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8208.

ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@ti-chi-bot
dmctl: fix error and add test for binlog-schema delete (#8180) (#8207)
8923c92 
close #7373
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@ti-chi-bot
dmctl: fix error and add test for binlog-schema delete (#8180) (#8208)
6d66687 
close #7373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binlog-schema delete is always failed
4 participants
@liumengya94 @ti-chi-bot @lance6716 @D3Hunter