Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(ticdc): add max-multi-update-row config in mysql sink (#8191) #8204

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8191

What problem does this PR solve?

Issue Number: ref #8084

What is changed and how it works?

  • Use GenUpdateSQLFast.
  • Based on benchmark with different table width and batch update size, we choose 40 as default max multi update row size.
  • If average row size is larger than MaxMultiUpdateRowSize (1024 by default), disable multi update SQL.
  • Besides add two more sink parameters. max-multi-update-row and max-multi-update-row-size
table-width=80 table-width=188
table-width=432 table-width=916

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 8, 2023
@ti-chi-bot ti-chi-bot added area/ticdc Issues or PRs related to TiCDC. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 15, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 756c7fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5db19d1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 39a1f2a differs from pull request most recent head 756c7fe. Consider uploading reports for the commit 756c7fe to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 66.7213% <0.0000%> (?)
dm 55.3129% <0.0000%> (?)
engine 66.5908% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.5      #8204   +/-   ##
================================================
  Coverage               ?   61.9634%           
================================================
  Files                  ?        867           
  Lines                  ?     112413           
  Branches               ?          0           
================================================
  Hits                   ?      69655           
  Misses                 ?      37302           
  Partials               ?       5456           

@amyangfei
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit a1a198e into pingcap:release-6.5 Feb 15, 2023
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants