Output fake txn when no entry event comes before a resolved event #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
reviewed
Nov 1, 2019
| @@ -129,6 +128,14 @@ func CollectRawTxns( | |||
| return err | |||
| } | |||
| } | |||
| if len(readyTxns) == 0 { | |||
There was a problem hiding this comment.
how about put L131 - L137 after L121
There was a problem hiding this comment.
What's the difference?
There was a problem hiding this comment.
if readyTxns is empty, we can skip the loop on L126.
There was a problem hiding this comment.
But never mind, not a big deal here.
|
LGTM |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
added a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We need to make sure heartbeat events are forwarded.
When we receive a resolved event and there's no entry event that comes with a smaller ts before it, we take it as a heartbeat event.
What is changed and how it works?
Wrap a resolved event as an empty RawTxn.
Check List
Tests
Code changes
Side effects
Related changes