Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new prow reviewing #8752

Merged
merged 5 commits into from
May 19, 2023
Merged

chore: migrate to new prow reviewing #8752

merged 5 commits into from
May 19, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023 •
edited
Loading

Signed-off-by: wuhuizuo wuhuizuo@126.com

What problem does this PR solve?

Issue Number: close #8965

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 6, 2023
@sre-bot
Copy link

sre-bot commented Apr 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 6, 2023
@wuhuizuo wuhuizuo added the skip-issue-check Indicates that a PR no need to check linked issue. label May 8, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 8, 2023
@wuhuizuo wuhuizuo marked this pull request as ready for review May 8, 2023 11:55
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented May 8, 2023

/check-issue-triage-complete

@wuhuizuo wuhuizuo removed the skip-issue-check Indicates that a PR no need to check linked issue. label May 16, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d3c5990

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@wuhuizuo
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1fd9889 into master May 19, 2023
@wuhuizuo
Copy link
Contributor Author

/cherry-pick release-7.1

@wuhuizuo wuhuizuo deleted the feature/review-config branch May 23, 2023 03:22
@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Merged
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #9018.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor Author

/cherry-pick release-6.1
/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Merged
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #9019.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Merged
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #9020.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#8752) (#9018)
95364d4 
close #8965
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#8752) (#9019)
258acb3 
close #8965
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#8752) (#9020)
0745619 
close #8965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

let's migrate to prow's lgtm + approve plugin for reviewing
5 participants
@wuhuizuo @ti-chi-bot @sre-bot @lance6716 @niubell