Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd, changefeed (ticdc): fix pd related issues (#8884, #8813, #9106, #9174) #8901

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 6, 2023

This is an manual cherry-pick of #8884 #8813 #9106 #9174

What problem does this PR solve?

Issue Number: close #8877 #8868 #8812 #8808 #9173 #9177

What is changed and how it works?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. deploy 1 tidb cluster with 3 pd and 2 cdc.
  2. create a changefeed
  3. kill pd leader
  4. no cdc processor exit abnormally

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix processor exit unexpectedly when some pd node fail

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels May 6, 2023
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels May 6, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 31, 2023
@asddongmen asddongmen force-pushed the cherry-pick-8884-to-release-6.1 branch from de50756 to 2b6426e Compare June 13, 2023 01:57
@asddongmen asddongmen changed the title capture (ticdc): fix processor exit unexpectedly when some pd node fail (#8884) pd, changefeed (ticdc): fix pd related issues (#8884, #8813, #9106, #9174) Jun 13, 2023
@asddongmen
Copy link
Contributor

/merge

@asddongmen
Copy link
Contributor

/run-all-tests

@asddongmen
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 03:18:19.265870496 +0000 UTC m=+55695.680474572: ☑️ agreed by asddongmen.
  • 2023-06-13 03:19:06.177097554 +0000 UTC m=+55742.591701632: ☑️ agreed by hi-rustin.

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot bot merged commit 1ea99d5 into pingcap:release-6.1 Jun 13, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants