Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc): add more unit test to cover checksum functionality #8990

Merged
merged 12 commits into from
May 23, 2023
Merged

test(ticdc): add more unit test to cover checksum functionality #8990

merged 12 commits into from
May 23, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented May 18, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8991

What is changed and how it works?

  • add unit test at the mounter to cover checksum functionality
  • add unit test at the avro encoder to cover checksum functionality
  • update tidb dependency to support query checksum from the mock test.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2023
@3AceShowHand
Copy link
Contributor Author

/test verify

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand 3AceShowHand reopened this May 22, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

10 similar comments
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023

@3AceShowHand: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/test engine-integration-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test engine-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 899a96a into pingcap:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add more unit test to cover checksum functionality
4 participants
@3AceShowHand @sdojjy @asddongmen @nongfushanquan