Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner, redo(ticdc): decouple globalResolvedTs and globalBarrierTs (#8964) #8995

Merged
merged 2 commits into from
May 25, 2023
Merged

owner, redo(ticdc): decouple globalResolvedTs and globalBarrierTs (#8964) #8995

merged 2 commits into from
May 25, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8964

What problem does this PR solve?

Issue Number: close #8963

What is changed and how it works?

  1. Decouple globalResolvedTs and globalBarrierTs.
  2. Add a redo ddl barrier to prevent resolvedTs from being advanced too early.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix the isuue that resolvedTs may be advanced too early when redo enabled`.

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2023
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 18, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-8964-to-release-6.5 branch from 640f36e to 104ec92 Compare May 22, 2023 04:00
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 22, 2023
@CharlesCheung96
Copy link
Contributor

/run-integration-tests

2 similar comments
@CharlesCheung96
Copy link
Contributor

/run-integration-tests

@CharlesCheung96
Copy link
Contributor

/run-integration-tests

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-8964-to-release-6.5 branch 5 times, most recently from a0881f5 to ad488f4 Compare May 23, 2023 06:30
@CharlesCheung96
Copy link
Contributor

/hold wait for #9022

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-8964-to-release-6.5 branch from ad488f4 to 0f34871 Compare May 25, 2023 02:18
@CharlesCheung96 CharlesCheung96 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@CharlesCheung96 CharlesCheung96 mentioned this pull request May 25, 2023
Closed
@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0f34871

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@CharlesCheung96
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot merged commit a2aaa4c into pingcap:release-6.5 May 25, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CharlesCheung96 CharlesCheung96

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @CharlesCheung96 @VelocityLight