sink(cdc): clear memquota when restart a table sink (#9091) #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot
added
release-note-none
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
hicqu
approved these changes
May 29, 2023
VelocityLight
added
cherry-pick-approved
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 9cfc3af
|
ti-chi-bot
bot
added
the
status/can-merge
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9091
What problem does this PR solve?
Issue Number: close #9092
What is changed and how it works?
The bug is introduced by #8949 . When restarting a table sink without re-build the processor, mem quota isn't cleared correctly.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note