-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol (#9079) #9127
Merged
ti-chi-bot
merged 10 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-9079-to-release-6.5
Jun 5, 2023
Merged
config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol (#9079) #9127
ti-chi-bot
merged 10 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-9079-to-release-6.5
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
labels
Jun 3, 2023
ti-chi-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
labels
Jun 3, 2023
/test all |
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 4, 2023
/retest |
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 4, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 4, 2023
/test all |
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 4, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 8, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 8, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
bot
removed
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 8, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 8, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 8, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 8, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
removed
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 14, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9079
What problem does this PR solve?
Issue Number: close #9086
What is changed and how it works?
enableOldValue
by the sink scheme and encoding protocol. if using avro / csv, always false.enable-old-value
.enable-old-value
false, do not drop columns for the delete event at the mounter side.OnlyHandleKeyColumns
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
For changefeed using avro or csv, with
force-replicate
set to true, after upgrade, the changefeed cannot work normally.Do you need to update user documentation, design documentation or monitoring documentation?
Yes, update document to describe that
enable-old-value
is always false if usingavro
orcsv
as the encoding protocol.Release note