Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed (ticdc): remove status of a changefeed after it is removed (#9174) #9183

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9174

What problem does this PR solve?

Issue Number: close #9173 #9177

What is changed and how it works?

Delete the status metric of a changefeed when it is removed.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 12, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2023
@ti-chi-bot ti-chi-bot added status/ptal Could you please take a look? type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2023
@asddongmen asddongmen force-pushed the cherry-pick-9174-to-release-6.5 branch from 7653c63 to a7d3507 Compare August 8, 2023 07:51
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-08 07:52:43.6679559 +0000 UTC m=+12728.216971882: ☑️ agreed by 3AceShowHand.
  • 2023-08-08 07:56:28.832873547 +0000 UTC m=+12953.381889519: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot merged commit 1bef076 into pingcap:release-6.5 Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/ptal Could you please take a look? type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants