Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support report error when replicate incompatible ddl #9856

Merged
merged 20 commits into from
Oct 12, 2023
Merged

ddl: support report error when replicate incompatible ddl #9856

merged 20 commits into from
Oct 12, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Oct 10, 2023

What problem does this PR solve?

Issue Number: close #9850

What is changed and how it works?

  • judge incompatible ddl changes for alter table

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

lichunzhu
lichunzhu approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dm/syncer/ddl.go Outdated
return bf.ExchangePartition
}
}
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
default:

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 11, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

okJiang
okJiang reviewed Oct 11, 2023
View reviewed changes
dm/syncer/ddl.go Outdated Show resolved Hide resolved
dm/syncer/ddl.go Show resolved Hide resolved
okJiang
okJiang reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/tests/incompatible_ddl_changes/run.sh Show resolved Hide resolved
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

2 similar comments
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2023

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-11 08:10:32.739589492 +0000 UTC m=+1212630.326699637: ☑️ agreed by lichunzhu.
  • 2023-10-12 03:06:38.85653129 +0000 UTC m=+1280796.443641437: ☑️ agreed by okJiang.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 12, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 12, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 433ba02 into pingcap:master Oct 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm: support report error when replicate incompatible ddl
3 participants
@GMHDBJD @lichunzhu @okJiang