This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Add minimal privileges test for backup using dynamic privs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
reviewed
Jun 9, 2021
| @@ -0,0 +1,48 @@ | |||
| module github.com/pingcap/tipocket/testcase/dynamicprivs | |||
|
|
|||
| go 1.15 | |||
There was a problem hiding this comment.
Suggested change
| go 1.15 | |
| go 1.16 |
Please bump the version to 1.16
bb7133
reviewed
Jun 9, 2021
|
|
||
| // Start implements the core.StandardClientExtensions interface. | ||
| func (c *Client) Start(ctx context.Context, cfg interface{}, clientNodes []cluster.ClientNode) error { | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This reopens #411
I discussed it with others, and there is a limitation in ticases in that it's not possible to change the DSN and effectively test the privilege system.
This depends on pingcap/tidb#25039 merging. If Ticases can support change user, we can migrate the test at a later point.
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?:
There is no imcompatibility or change - if users want to keep allocating SUPER privilege to backup operators, they can still do that. However, we should encourage principal of least privilege to our users for security best practice. So from that perspective, there is a user-facing change that using
BACKUP_ADMINandRESTORE_ADMINwill be encouraged overSUPER.