Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using stream rather removeIf #1057

Merged
merged 3 commits into from
Aug 23, 2019
Merged

using stream rather removeIf #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f17bfe
using stream rather removeIf
zhexuany Aug 22, 2019
362e24f
fix ci
zhexuany Aug 22, 2019
989318a
address reviewer
zhexuany Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/test/scala/org/apache/spark/sql/ViewTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,7 @@ class ViewTestSuite extends BaseTiSparkTest {

judge(s"select * from $table")
intercept[AnalysisException](spark.sql("select * from v"))

spark.sql("show tables").show(false)
}
}
}
3 changes: 1 addition & 2 deletions tikv-client/src/main/java/com/pingcap/tikv/catalog/Catalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ public List<TiTableInfo> listTables(TiDBInfo db) {
tableMap = loadTables(db);
}
Collection<TiTableInfo> tables = tableMap.values();
tables.removeIf(TiTableInfo::isView);
return ImmutableList.copyOf(tables);
return tables.stream().filter(tbl -> !tbl.isView()).collect(Collectors.toList());
}

public TiTableInfo getTable(TiDBInfo db, String tableName) {
Expand Down