Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recreate flag when creating TiSession #1116

Conversation

guliangliangatpingcap
Copy link
Contributor

@guliangliangatpingcap guliangliangatpingcap commented Sep 23, 2019

What problem does this PR solve?

This PR #1064 adds a recreate flag in TiSession to fix ci failure.

This PR #1108 fixes no such table problem, so the recreate flag could be removed.

close #1058

What is changed and how it works?

Remove recreate flag when creating TiSession

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@guliangliangatpingcap guliangliangatpingcap changed the title Remove recreate flag when create TiSession Remove recreate flag when creating TiSession Sep 23, 2019
@guliangliangatpingcap
Copy link
Contributor Author

/run-all-tests mode=full

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guliangliangatpingcap guliangliangatpingcap merged commit 339f025 into pingcap:master Sep 23, 2019
guliangliangatpingcap added a commit to guliangliangatpingcap/tispark that referenced this pull request Sep 23, 2019
guliangliangatpingcap added a commit that referenced this pull request Sep 25, 2019
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Randomly observe NoSuchTableException in tests (unstable)
2 participants