fix view #1174
Merged
fix view #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
| @@ -4,23 +4,29 @@ class ViewTestSuite extends BaseTiSparkTest { | |||
| private val table = "test_view" | |||
|
|
|||
| test("Test View") { | |||
| tidbStmt.execute(s"drop table if exists $table") | |||
There was a problem hiding this comment.
what if there's some dirty data (e.g. a table named test_view) in database?
There was a problem hiding this comment.
afterAll will drop it.
There was a problem hiding this comment.
but we should still drop it before each test
There was a problem hiding this comment.
Is it partitionTableSuite? If you take a look at afterAll, you will find that table t is not dropped at afterAll.
| try { | ||
| tidbStmt.execute("drop view if exists v") |
There was a problem hiding this comment.
what if there's some dirty data (e.g. a view named v) in database?
There was a problem hiding this comment.
afterAll will drop it.
|
@birdstorm would u please add more information to the commit message? |
zhexuany
added a commit
to zhexuany/tispark
that referenced
this pull request
Oct 30, 2019
zhexuany
added a commit
that referenced
this pull request
Oct 31, 2019
zhexuany
added a commit
that referenced
this pull request
Oct 31, 2019
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes TiSpark cannot parse view table's json.
What is changed and how it works?
ViewCols could be null. If such case happens, we do not need parse viewCols.
Tests