fix parition table isn't shown in show command #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhexuany
changed the title
zhexuany
force-pushed
the
fix_partition_table_in_show_table_command
branch
from
9a83850
to
135533c
Compare
|
can you add a test? |
|
@birdstorm Yes, I was figuring out how to add a test. :( |
You may refer to https://github.com/pingcap/tispark/blob/0f5135c/core/src/test/scala/org/apache/spark/sql/catalyst/catalog/CatalogTestSuite.scala#L61-L108 |
|
need cherry-pick? |
Yes, this PR need cherry pick. |
|
@zhexuany please add tags to specify branches to cherry-pick to. |
|
/run-all-tests |
|
cherry pick to release-2.2 in PR #1373 |
|
cherry pick to release-2.1 in PR #1374 |
birdstorm
pushed a commit
that referenced
this pull request
Jan 16, 2020
birdstorm
pushed a commit
that referenced
this pull request
Jan 16, 2020
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR closes #1330
What is changed and how it works?
When we process
ShowCommand, we first check the emptiness ofpartitionSpec. We append partition info if such spec is not empty.Check List
Tests
tests will be added later.