Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: fix the resolved txn status cache for pessimistic txn #1868

Conversation

marsishandsome
Copy link
Collaborator

What problem does this PR solve?

Solve the incorrect transaction status cache for resolve pessimistic primary key lock.

see pingcap/tidb#21689

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@marsishandsome marsishandsome added needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 labels Dec 16, 2020
Copy link

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.5 tidb=v4.0.5 pd=v4.0.5

@marsishandsome marsishandsome merged commit afe381d into pingcap:release-2.3 Dec 16, 2020
@ti-srebot
Copy link
Collaborator

cherry pick to release-2.4 failed

@ti-srebot
Copy link
Collaborator

cherry pick to master failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants