Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape for StringRegExpression #2775

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Fix escape for StringRegExpression #2775

merged 3 commits into from
Mar 27, 2024

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Mar 21, 2024 •
edited
Loading

What problem does this PR solve?

TiSpark does not support escape in like expression before.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot bot requested a review from zhangyangyu March 21, 2024 10:20
@ti-chi-bot ti-chi-bot bot added the size/S label Mar 21, 2024
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=v6.5.0 tikv=v6.5.0 pd=v6.5.0

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=v6.5.0 tikv=v6.5.0 pd=v6.5.0

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

2 similar comments
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.4 tikv=release-6.4 pd=release-6.4

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.6 tikv=release-6.6 pd=release-6.6

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1

@shiyuhang0 shiyuhang0 closed this Mar 27, 2024
@shiyuhang0 shiyuhang0 reopened this Mar 27, 2024
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuanyu66, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 07:46:10.384465969 +0000 UTC m=+2053997.406712349: ☑️ agreed by zhangyangyu.
  • 2024-03-27 08:11:07.497634972 +0000 UTC m=+2055494.519881355: ☑️ agreed by xuanyu66.

@ti-chi-bot ti-chi-bot bot merged commit c82c4c7 into pingcap:master Mar 27, 2024
14 checks passed
@shiyuhang0
Copy link
Member Author

/cherry-pick release-3.2

@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request created to branch release-3.2: #2776.

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2024
Merged
shiyuhang0 added a commit that referenced this pull request Mar 28, 2024
@ti-chi-bot @shiyuhang0
Fix escape for StringRegExpression (#2775) (#2776)
ce46f0c 
* fix

* fmt

* fix

---------

Co-authored-by: shiyuhang <1136742008@qq.com>
@zhangyangyu zhangyangyu deleted the fix_escape branch April 1, 2024 13:22
@seiya-annie
Copy link

/found community

1 similar comment
@seiya-annie
Copy link

/found community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees
No one assigned
Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shiyuhang0 @ti-chi-bot @seiya-annie @zhangyangyu @xuanyu66