Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve TiConfiguration getPdAddrsString function #963

Merged
merged 6 commits into from
Aug 5, 2019
Merged

improve TiConfiguration getPdAddrsString function #963

merged 6 commits into from
Aug 5, 2019

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jul 31, 2019 •
edited
Loading

What problem does this PR solve?

use self-made toString function for TiConfiguration 's getPdAddrsString, in order to make it easy to understand the code

close #969

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from 56b2996 to 0945379 Compare July 31, 2019 02:21
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from 0945379 to cefb84e Compare July 31, 2019 06:09
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

ilovesoup
ilovesoup reviewed Jul 31, 2019
View reviewed changes
tikv-client/src/main/java/com/pingcap/tikv/TiConfiguration.java
@@ -125,7 +125,20 @@ public TiConfiguration setTimeoutUnit(TimeUnit timeoutUnit) {
}

public String getPdAddrsString() {
return pdAddrs.toString();
return listToString(pdAddrs);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to cache it? It seems we are using this one as hash key.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

ilovesoup
ilovesoup reviewed Jul 31, 2019
View reviewed changes
tikv-client/src/main/java/com/pingcap/tikv/TiSessionCache.java Outdated
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* See the License for the specific language governing permissions and
* limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache might be moved into TiSession if we want to ensure no double creation for each session. Or we can leave it in factory but make TiSession create method private.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, done, PTAL again

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

ilovesoup
ilovesoup approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

1 similar comment
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from b8a239c to 0f9cb33 Compare August 5, 2019 02:16
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

4 similar comments
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from d5e532e to 1e7a8b7 Compare August 5, 2019 05:30
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from 1e7a8b7 to 1f898e3 Compare August 5, 2019 05:59
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from 1f898e3 to 5b10245 Compare August 5, 2019 06:17
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

@marsishandsome marsishandsome force-pushed the feature/improve-getPdAddrsString branch from 1fec162 to cb00420 Compare August 5, 2019 07:57
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v3.0.1 tidb=v3.0.1 pd=v3.0.1

@marsishandsome marsishandsome merged commit 0c3bcfe into pingcap:master Aug 5, 2019
marsishandsome added a commit that referenced this pull request Aug 29, 2019
@marsishandsome
release-2.2 branch merge master (#1078)
5aeb1b8 
* 2.2.0 -> 2.3.0 (#947)

* Add tests for primary key (#948)

* add changelog (#955)

* add multi-column tests (#954)

* fix range partition throw UnsupportedSyntaxException error (#960)

* fix view parsing problem (#953)

* make tispark can read from a hash partition table (#966)

* increase ci worker number (#965)

* update readme for tispark-2.1.2 release (#968)

* update document for pyspark (#975)

* fix one jar bug (#972)

* adding common port number used by spark cluster (#973)

* fix cost model in table scan (#977)

* create an UninitializedType for TypeDecimal (#979)

* update sparkr doc (#976)

* use spark-2.4.3 to run ut (#978)

* use spark-2.4.3 to run ut

* fix ci

* a better design for get auto table id (#980)

* fix bug: ci SpecialTiDBTypeTestSuite failed with tidb-3.0.1 (#984)

* improve TiConfiguration getPdAddrsString function (#963)

* bump grpc to 1.17 (#982)

* Add multiple-column PK tests (#970)

* add retry for batchGet (#986)

* use tispark self-made m2 cahce file (#990)

* add spark sql document for batch write (#991)

* add auto mode for test.data.load (#994)

* fix typo (#996)

* fix index scan bug (#995)

* refine doc (#1003)

* add tidb-3.0 compatibility document (#998)

* add tidb-3.0 compatibility document

* address code review

* address code review

* add log4j config document (#1008)

* refactor batch write region pre-split (#999)

* add ci simple mode (#1012)

* clean up redundant code (#997)

* prohibit agg or groupby pushdown on double read (#1004)

* remove split region code (#1015)

* add supported scala version (#1013)

* Fix scala compiler version (#1010)

* fix reflection bug for hdp release (#1017) (#1018)

(cherry picked from commit 118b12e)

* check by grammarly (#1022)

* add benchmark result for batch write (#1025)

* release tispark 2.1.3 (#1026) (#1035)

(cherry picked from commit 107eb2b)

* support setting random seed in daily regression test (#1032)

* Remove create in tisession (#1021)

* set tikv region size from 96M to 1M (#1031)

* adding unique indices test for batch write (#1014)

* use one unique seed (#1043)

* remove unused code (#1030)

* adding batch write pk insertion test (#1044)

* fix table not found bug in TiSession because of synchronization (#1041)

* fix test failure (#1051)

* fix reflection bug: pass in different arguments for different version of same function (#1037) (#1052)

(cherry picked from commit a5462c2)

* Adding pk and unique index test for batch write (#1049)

* fix distinct without alias bug: disable pushdown aggregate with alias (#1054)

* improve the doc (#1053)

* Refactor RegionStoreClient logic (#989)

* using stream rather removeIf (#1057)

* Remove redundant pre-write/commit logic in LockResolverTest (#1062)

* adding recreate flag when create tisession (#1064)

* fix issue 1047 (#1066)

* cleanup code in TiBatchWrite (#1067)

* release tispark-2.1.4 (#1068) (#1069)

(cherry picked from commit fd8068a)

* update document for tispark-2.1.4 release (#1070)
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@marsishandsome
improve TiConfiguration getPdAddrsString function (pingcap#963)
b2092a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhexuany zhexuany zhexuany left review comments

@birdstorm birdstorm birdstorm approved these changes

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve TiConfiguration getPdAddrsString function
4 participants
@marsishandsome @ilovesoup @zhexuany @birdstorm