Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: add workaround for different *_exporter locations #1101

Merged
merged 1 commit into from
Jan 26, 2021
Merged

cluster: add workaround for different *_exporter locations #1101

merged 1 commit into from
Jan 26, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1097

What is changed and how it works?

Add a check in startup script to check and workaround both binary path schemes.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: fix monitoring agents starting up failure after importing from ansible

@AstroProfundis AstroProfundis added type/bug-fix Categorizes PR as a bug-fix category/stability Categorizes issue or PR as a stability enhancement. labels Jan 26, 2021
@AstroProfundis AstroProfundis added this to the v1.3.2 milestone Jan 26, 2021
@AstroProfundis AstroProfundis self-assigned this Jan 26, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 26, 2021
@ti-chi-bot ti-chi-bot requested a review from nrc January 26, 2021 11:14
@AstroProfundis AstroProfundis added ansible Categorizes issue as related to tidb-ansible category/monitoring Categorizes issue or PR related to monitoring components. labels Jan 26, 2021
@AstroProfundis AstroProfundis removed the request for review from nrc January 26, 2021 11:15
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 933f615

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-chi-bot ti-chi-bot merged commit 7f94ef7 into pingcap:master Jan 26, 2021
lucklove pushed a commit that referenced this pull request Jan 28, 2021
@AstroProfundis @lucklove
cluster: add workaround for different *_exporter locations (#1101)
ef675e3
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 29, 2021
@AstroProfundis @mianhk
cluster: add workaround for different *_exporter locations (pingcap#1101
5a26cbd 
)
@AstroProfundis AstroProfundis deleted the fix-exporter branch March 1, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@AstroProfundis AstroProfundis

Labels
ansible Categorizes issue as related to tidb-ansible category/monitoring Categorizes issue or PR related to monitoring components. category/stability Categorizes issue or PR as a stability enhancement. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.

tiup cluster restart failed because of the node_expoter binary path
3 participants
@AstroProfundis @lucklove @ti-chi-bot