Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dm enable disable #1114

Merged
merged 7 commits into from
Feb 1, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jan 30, 2021

What problem does this PR solve?

fix(implement) #1110

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

dm add enable/disable subcommands

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2021
@codecov-io
Copy link

codecov-io commented Jan 30, 2021

Codecov Report

Merging #1114 (00223ce) into master (d90ee6a) will decrease coverage by 16.47%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1114       +/-   ##
===========================================
- Coverage   56.61%   40.13%   -16.48%     
===========================================
  Files         283      284        +1     
  Lines       20127    20157       +30     
===========================================
- Hits        11395     8091     -3304     
- Misses       6972    10791     +3819     
+ Partials     1760     1275      -485     
Flag Coverage Δ
cluster ?
dm 23.58% <74.35%> (-1.21%) ⬇️
integrate 31.25% <74.35%> (-19.75%) ⬇️
playground 20.89% <ø> (ø)
tiup 16.31% <0.00%> (-0.03%) ⬇️
unittest 22.98% <32.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/disable.go 66.66% <66.66%> (ø)
components/dm/command/enable.go 66.66% <66.66%> (ø)
pkg/cluster/spec/instance.go 53.73% <66.66%> (-10.94%) ⬇️
components/cluster/command/disable.go 38.46% <100.00%> (-30.77%) ⬇️
components/dm/command/deploy.go 72.22% <100.00%> (+3.47%) ⬆️
components/dm/command/root.go 50.00% <100.00%> (-4.77%) ⬇️
components/dm/command/scale_out.go 77.77% <100.00%> (-10.46%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90ee6a...00223ce. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2021
@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. type/new-feature Categorizes pr as related to a new feature. labels Feb 1, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Feb 1, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5111833

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 1, 2021
@ti-chi-bot
Copy link
Member

@9547: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f54c265 into pingcap:master Feb 1, 2021
@9547 9547 deleted the feature/dm-enable-disable branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants