Refine cluster list and display commands

[baurine]

What problem does this PR solve?

In related PR #706 (tiup cluster UI), I need interfaces to get the cluster list and instances of a cluster.

I have implemented it in #706 , but I often need to handle conflicts when the master changes the related code, so I decide to cherry-pick this part of the code to the master.

What is changed and how it works?

• Extract GetClusterList() method from ListCluster() method
• Extract GetClusterTopology() method from Display() method

Check List

Tests

• Unit test
• Integration test

Code changes

• Has exported function/method change
• Has exported variable/fields change

Release notes:

NONE

[codecov-io]

Codecov Report

Merging #1139 (5084f9e) into master (b769ff8) will decrease coverage by 5.73%.
The diff coverage is 81.52%.

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   53.93%   48.20%   -5.74%     
==========================================
  Files         273      285      +12     
  Lines       19854    20317     +463     
==========================================
- Hits        10709     9793     -916     
- Misses       7499     8999    +1500     
+ Partials     1646     1525     -121     

Flag	Coverage Δ
cluster	35.86% <80.43%> (-9.08%)	⬇️
dm	25.66% <68.47%> (+0.15%)	⬆️
integrate	42.34% <81.52%> (-8.50%)	⬇️
playground	2.93% <ø> (?)
tiup	16.36% <ø> (-0.03%)	⬇️
unittest	22.90% <0.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/manager/display.go	82.02% <80.55%> (-1.32%)	⬇️
pkg/cluster/manager/list.go	78.57% <85.00%> (+2.10%)	⬆️
pkg/queue/any_queue.go	0.00% <0.00%> (-83.34%)	⬇️
pkg/cluster/task/limits.go	0.00% <0.00%> (-68.75%)	⬇️
pkg/cluster/task/sysctl.go	0.00% <0.00%> (-66.67%)	⬇️
components/cluster/command/check.go	5.97% <0.00%> (-63.86%)	⬇️
pkg/cluster/task/copy_file.go	0.00% <0.00%> (-54.55%)	⬇️
components/cluster/command/audit.go	27.27% <0.00%> (-54.55%)	⬇️
pkg/cluster/task/rmdir.go	0.00% <0.00%> (-50.00%)	⬇️
pkg/cluster/manager/patch.go	0.00% <0.00%> (-49.46%)	⬇️
... and 66 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b769ff8...5084f9e. Read the comment docs.

[baurine]

@lucklove please help take a look, thanks!

[AstroProfundis]

Could you post a screenshot of what the output of display command is like now? I believe it didn't change the console output?

Also, did you tested with dm component? The manager part is shared by dm and cluster AFAIK.

[baurine]

Could you post a screenshot of what the output of display command is like now? I believe it didn't change the console output?

Also, did you tested with dm component? The manager part is shared by dm and cluster AFAIK.

Sure, I did the test manually, and the outputs are exactly the same.

[baurine]

How do I test with dm component? I never used dm before.

[AstroProfundis]

dm should work much like cluster, only that it deploys a DM cluster.

[baurine]

Manaully test result for tiup dm:

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[AstroProfundis]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 19b7b85

[ti-chi-bot]

@baurine: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.