Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retry publish on checksum validation failure #1202

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

When multiple release jobs are publishing package in parallel, the snapshot may be updated after client fetched timestamp but before it fetching the snapshot file.

What is changed and how it works?

If a checksum mismatch error is reported during publish, just retry the operation.

Check List

Tests

  • Integration test

Release notes:

NONE

@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Mar 10, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Mar 10, 2021
@AstroProfundis AstroProfundis self-assigned this Mar 10, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15db208

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2021
@ti-chi-bot ti-chi-bot merged commit 7076c6c into master Mar 10, 2021
@ti-chi-bot ti-chi-bot deleted the ci/gh-retry-publish branch March 10, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants