Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster&dm/display: add an option to only show cluster version #1207

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Add an option --version to display subcommand of cluster and dm to only print cluster version to console.

This could be helpful for scripting, an sample usage case would be getting ctl with the same version as an deployed cluster.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    图片

Related changes

  • Need to update the documentation

Release notes:

Add an option to `display` subcommand to only show cluster version.

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. labels Mar 12, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Mar 12, 2021
@AstroProfundis AstroProfundis self-assigned this Mar 12, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8384bcd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2021
@ti-chi-bot ti-chi-bot merged commit 1968a99 into pingcap:master Mar 15, 2021
@AstroProfundis AstroProfundis deleted the cluster-ver branch March 15, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants