-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: cache timestamp.json to accelerate #1212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 52.43% 47.79% -4.64%
==========================================
Files 289 288 -1
Lines 20563 20564 +1
==========================================
- Hits 10782 9829 -953
- Misses 8085 9021 +936
- Partials 1696 1714 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/hold unit tests are failing |
/unhold /merge |
This pull request has been accepted and is ready to merge. Commit hash: 8ddf0f4
|
What problem does this PR solve?
We implemented a base function,
ensureManifests()
, which will fetchn.root.json
andtimestamp.json
, and if the timestamp.json is a new one, fetchsnapshot.json
and{component}.json
.However, there are many places invoke
ensureManifests()
and TiUP will fetchtimestamp.json
androot.json
many times even though there is no change on them, which cause TiUP run slowly.What is changed and how it works?
Cache
timestamp.json
in memory so that TiUP will only fetch it once every time the user execute TiUP command.Check List
Tests
Code changes
Side effects
Related changes
Release notes: