Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: reload shoud pass through ignore-config-check #1265

Merged
merged 3 commits into from
Apr 3, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Apr 1, 2021

What problem does this PR solve?

A temporary repair of the issue reported via https://asktug.com/t/topic/69400

What is changed and how it works?

The root cause of that problem is that the configuration of Prometheus is inconsistent between the two versions. The previous configuration via ansilbe maybe had problems.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2021
@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #1265 (ec9e367) into master (c211098) will decrease coverage by 13.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1265       +/-   ##
==========================================
- Coverage   16.52%   3.10%   -13.43%     
==========================================
  Files         145      79       -66     
  Lines       11406    6966     -4440     
==========================================
- Hits         1885     216     -1669     
+ Misses       9031    6724     -2307     
+ Partials      490      26      -464     
Flag Coverage Δ
integrate 3.10% <ø> (-13.43%) ⬇️
playground 3.10% <ø> (?)
tiup ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/environment/tiup.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/progress.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/localdata/config.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/repository/v1manifest/types.go 0.00% <0.00%> (-61.54%) ⬇️
pkg/repository/v1manifest/keys.go 0.00% <0.00%> (-60.00%) ⬇️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c211098...ec9e367. Read the comment docs.

@lucklove lucklove added this to the v1.4.1 milestone Apr 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: faf241f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2021
@ti-chi-bot
Copy link
Member

@9547: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e60f822 into pingcap:master Apr 3, 2021
@9547 9547 deleted the fix/regen-ignore-check branch April 5, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants