Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: check for global configs and prompt user for confirmation on… #1309

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

AstroProfundis
Copy link
Contributor

… scale-out

What problem does this PR solve?

Close #1293

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Increased code complexity

Release notes:

NONE

@AstroProfundis AstroProfundis added the type/new-feature Categorizes pr as related to a new feature. label Apr 14, 2021
@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Apr 14, 2021
@AstroProfundis AstroProfundis self-assigned this Apr 14, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2021
@AstroProfundis AstroProfundis marked this pull request as ready for review April 14, 2021 11:52
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 935addc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #1309 (f2da556) into master (8c5e7d2) will increase coverage by 13.91%.
The diff coverage is 33.33%.

❗ Current head f2da556 differs from pull request most recent head a5d0999. Consider uploading reports for the commit a5d0999 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1309       +/-   ##
===========================================
+ Coverage   26.27%   40.19%   +13.91%     
===========================================
  Files         263      254        -9     
  Lines       18974    17917     -1057     
===========================================
+ Hits         4986     7202     +2216     
+ Misses      13215     9498     -3717     
- Partials      773     1217      +444     
Flag Coverage Δ
cluster 35.51% <33.33%> (?)
dm 26.14% <33.33%> (?)
integrate 40.19% <33.33%> (+23.69%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/scale_out.go 37.07% <21.05%> (+25.65%) ⬆️
pkg/cluster/spec/parse_topology.go 78.46% <62.50%> (-1.20%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/scrub.go 6.66% <0.00%> (-80.00%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
... and 223 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5e7d2...a5d0999. Read the comment docs.

@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ba88036 into pingcap:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP should raise error while scale-out with global configurations
4 participants